-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb-in-kubernetes: make deploy doc clearer on GCP #1570
Conversation
@DanielZhangQD all comments addressed. PTAL again, thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for v3.0
~
@yikeke All comments addressed, PTAL again~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is changed, added or deleted?
This PR updates deploy doc on GCP to make it clearer.
What is the related PR or file link(s)?
pingcap/docs-cn#1903
Which version does your change affect?
dev, v3.0