Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb-in-kubernetes: make deploy doc clearer on GCP #1570

Merged
merged 13 commits into from
Oct 11, 2019

Conversation

anotherrachel
Copy link
Contributor

What is changed, added or deleted?

This PR updates deploy doc on GCP to make it clearer.

What is the related PR or file link(s)?

pingcap/docs-cn#1903

Which version does your change affect?

dev, v3.0

@anotherrachel anotherrachel added dev area/tidb-in-k8s-v1.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Oct 8, 2019
@anotherrachel anotherrachel marked this pull request as ready for review October 8, 2019 10:30
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
@anotherrachel
Copy link
Contributor Author

@DanielZhangQD all comments addressed. PTAL again, thanks~

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for v3.0~

dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
dev/tidb-in-kubernetes/deploy/gcp-gke.md Outdated Show resolved Hide resolved
@anotherrachel
Copy link
Contributor Author

@yikeke All comments addressed, PTAL again~

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit e7a6ba5 into pingcap:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tidb-in-k8s-v1.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants