tidb-in-kubernetes: make deploy doc clearer on GCP #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomShawn
reviewed
Sep 27, 2019
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
|
Please do not merge this PR until pingcap/tidb-operator#959 is merged. |
TomShawn
reviewed
Sep 29, 2019
Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
|
@TomShawn comments addressed, PTAL again. |
anotherrachel
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
Update deploy doc on GCP to make it clearer
What is the related PR or file link(s)?
Which version does your change affect?
dev, v3.0