Add provider versions constraint for GCP and Aliyun and support values file customization for tidb-operator and tidb-cluster #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-in-kind |
cofyc
reviewed
Sep 27, 2019
deploy/gcp/main.tf
Outdated
| @@ -50,7 +50,7 @@ module "tidb-operator" { | |||
| kubeconfig_path = local.kubeconfig | |||
| tidb_operator_version = var.tidb_operator_version | |||
| maintenance_window_start_time = var.maintenance_window_start_time | |||
| operator_helm_values = var.operator_helm_values | |||
| operator_helm_values = var.operator_helm_values == "" ? "" : file(var.operator_helm_values) | |||
There was a problem hiding this comment.
inline yaml values is sometimes convenient, short and no external file required. How about adding a new variable for file support?
operator_helm_values = <<EOF
operatorImage: quay.io/cofyc/tidb-operator:canary
imagePullPolicy: Always
EOF
There was a problem hiding this comment.
OK, I thought it was designed for external values file, will revert the change.
|
/run-e2e-in-kind |
DanielZhangQD
changed the title
|
/run-e2e-in-kind |
DanielZhangQD
changed the title
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
@aylei CI passed, PTAL again. |
|
cherry pick to release-1.0 failed |
DanielZhangQD
added a commit
that referenced
this pull request
Sep 29, 2019
…P and Aliyun (#967) * add provider version constraint for GCP and Aliyun * Support customized values file for tidb-operator and tidb-cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #958
What is changed and how does it work?
Add version constraint for providers.
Modify terraform scripts to support values customization for tidb-operator and tidb-cluster.
Check List
Tests
terraform initdoes not prompt for version constraint any moreCode changes
Side effects
NONE
Related changes
Does this PR introduce a user-facing change?: