Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add 3 docs disable/display/list #5176

Merged
merged 16 commits into from
Apr 7, 2021
Merged

tiup: add 3 docs disable/display/list #5176

merged 16 commits into from
Apr 7, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 31, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

add 3 TiUP docs:

  • tiup/tiup-component-cluster-disable.md
  • tiup/tiup-component-cluster-display.md
  • tiup/tiup-component-cluster-list.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 6, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label translation/from-docs-cn

@ti-chi-bot
Copy link
Member

@Joyinqin: The label(s) translation/from-docs-cn cannot be applied. These labels are supported: Hacktoberfest, contribution, first-time-contributor, requires-followup, good-first-issue, hacktoberfest-accepted, help-wanted, needs-cherry-pick-2.1, needs-cherry-pick-3.0, needs-cherry-pick-3.1, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-master, question, require-LGT1, require-LGT2, require-LGT3, special-week, v4.0, v5.0, for-future-release, requires-version-specific-changes, website.

In response to this:

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label translation/from-docs-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 6, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 6, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 6, 2021
Merged
11 tasks
@Joyinqin Joyinqin marked this pull request as ready for review April 6, 2021 10:37
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 6, 2021

/cc @ran-huang @lucklove

ran-huang
ran-huang reviewed Apr 7, 2021
View reviewed changes
tiup/tiup-component-cluster-disable.md Outdated
tiup cluster disable <cluster-name> [flags]
```

`<cluster-name>`: the cluster to disable the auto-enabling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`<cluster-name>`: the cluster to disable the auto-enabling.
`<cluster-name>`: the cluster whose auto-enabling service is to be disabled.

tiup/tiup-component-cluster-disable.md Outdated

- Data type: `strings`
- Default: `[]`, which means no node is selected.
- Specifies the nodes to disable the auto-enabling. The value of this option is a comma-separated list of node IDs. The node ID is the first column of the [cluster status](/tiup/tiup-component-cluster-display.md) table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tiup/tiup-component-cluster-disable.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-disable.md Outdated

- Data type: `strings`
- Default: `[]`, which means no role is selected.
- Specifies the roles to disable the auto-enabling. The value of this option is a comma-separated list of node roles. The role is the second column of the [cluster status](/tiup/tiup-component-cluster-display.md) table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the first comment

tiup/tiup-component-cluster-disable.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-display.md Outdated

> **Note:**
>
> If `-N, --node` are specified at the same time, then the service status in their intersection is queried.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

tiup/tiup-component-cluster-list.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-list.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-list.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-list.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor

/retitle tiup: add 3 docs disable/display/list

@ran-huang
Copy link
Contributor

/label require-LGT1
/hold

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. require-LGT1 Indicates that the PR requires an LGTM. labels Apr 7, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 308350e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
Joyinqin and others added 2 commits April 7, 2021 11:46
@Joyinqin
Copy link
Contributor Author

Joyinqin commented Apr 7, 2021

@lucklove PTAL again thx~

@lucklove
Copy link
Member

lucklove commented Apr 7, 2021

/lgtm

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2021
@ti-chi-bot
Copy link
Member

@Joyinqin: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 774e388

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 7, 2021
@ti-chi-bot ti-chi-bot merged commit 21c8bac into pingcap:master Apr 7, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5176 to release-4.0
a48c373 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5242

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 7, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5176 to release-5.0
1f80ea5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 7, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5243

@Joyinqin Joyinqin deleted the tiup-joyin5 branch April 7, 2021 08:44
ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
tiup: add 3 docs disable/display/list (#5176) (#5243)
116d64a
ti-chi-bot pushed a commit that referenced this pull request Apr 7, 2021
@ti-srebot
tiup: add 3 docs disable/display/list (#5176) (#5242)
6d75e0f
@CharLotteiu CharLotteiu mentioned this pull request Apr 13, 2021
Merged
10 tasks
This was referenced Apr 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@lucklove lucklove lucklove left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @ti-chi-bot @ran-huang @lucklove @ti-srebot