Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add 3 docs mirror-init/mirror-rotate/cluster-patch #5310

Merged
merged 9 commits into from
Apr 15, 2021
Merged

tiup: add 3 docs mirror-init/mirror-rotate/cluster-patch #5310

merged 9 commits into from
Apr 15, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add documents for commands mirror init, mirror rotate, and cluster patch.

Add 3 docs:

  • tiup/tiup-component-mirror-init.md
  • tiup/tiup-component-mirror-rotate.md
  • tiup/tiup-component-cluster-patch.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-zh
/cc @lucklove @TomShawn

@ti-chi-bot
Copy link
Member

@CharLotteiu: The label(s) translation/from-zh cannot be applied, because the repository doesn't have them.

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-zh
/cc @lucklove @TomShawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 13, 2021
@CharLotteiu
Copy link
Contributor Author

Waiting on #5285 and #5176 to be merged to fix the CI.

@Joyinqin Joyinqin mentioned this pull request Apr 14, 2021
Merged
11 tasks
@TomShawn
Copy link
Contributor

@CharLotteiu See #5285 (comment).

TomShawn
TomShawn reviewed Apr 14, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor edits

tiup/tiup-command-mirror-rotate.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-rotate.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-rotate.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-rotate.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-rotate.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-patch.md Outdated Show resolved Hide resolved
@CharLotteiu @TomShawn
Apply suggestions from code review
2f0b2f6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lucklove
Copy link
Member

Rest LGTM

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0057947

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot merged commit d1cf6da into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5310 to release-4.0
75d8d3d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5341

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5310 to release-5.0
670809f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5342

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 3 docs mirror-init/mirror-rotate/cluster-patch (#5310) (#5341)
da51785
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 3 docs mirror-init/mirror-rotate/cluster-patch (#5310) (#5342)
5a76acf
@CharLotteiu CharLotteiu deleted the tiup-docs-3 branch April 16, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lucklove lucklove lucklove left review comments

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharLotteiu @ti-chi-bot @TomShawn @lucklove @ti-srebot