Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: add 4 docs dm-edit config/help/scale in/scale out #5282

Merged
merged 110 commits into from
Apr 15, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 9, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add 4 docs:

  • tiup/tiup-component-dm-edit-config.md
  • tiup/tiup-component-dm-help.md
  • tiup/tiup-component-dm-scale-in.md
  • tiup/tiup-component-dm-scale-out.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Joyinqin and others added 30 commits November 12, 2020 10:33
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2021
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiup/tiup-component-dm-edit-config.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-edit-config.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-scale-out.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-scale-out.md Outdated Show resolved Hide resolved
Co-authored-by: Ran <huangran@pingcap.com>
@Joyinqin
Copy link
Contributor Author

/sig tiup

@ti-chi-bot ti-chi-bot added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Apr 13, 2021
Co-authored-by: Ran <huangran@pingcap.com>
@Joyinqin
Copy link
Contributor Author

/sig docs

@ti-chi-bot ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 13, 2021
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 13, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 13fcbe2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot merged commit 4a3774c into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5332

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants