Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add 4 docs dm-prune/start/stop/reload #5308

Merged
merged 15 commits into from
Apr 15, 2021
Merged

tiup: add 4 docs dm-prune/start/stop/reload #5308

merged 15 commits into from
Apr 15, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

add 4 docs:

  • tiup/tiup-component-dm-reload.md
  • tiup/tiup-component-dm-prune.md
  • tiup/tiup-component-dm-start.md
  • tiup/tiup-component-dm-stop.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 13, 2021
@Joyinqin
Copy link
Contributor Author

/cc @lucklove @ran-huang

@Joyinqin
Copy link
Contributor Author

/sig tiup

@ti-chi-bot ti-chi-bot added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Apr 13, 2021
@ran-huang
Copy link
Contributor

/sig docs

@ti-chi-bot ti-chi-bot added the sig/docs Indicates that the Issue or PR belongs to the docs SIG. label Apr 13, 2021
@Joyinqin
Copy link
Contributor Author

Wait for #5282, #5291, #5270 to merge to fix the dead links.

@ran-huang
Copy link
Contributor

@Joyinqin CI failed again 😭

CharLotteiu
CharLotteiu reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-dm-prune.md Outdated

# tiup dm prune

When [scaling in the cluster]<!--(/tiup/tiup-component-dm-scale-in.md) -->, a small amount of metadata in etcd is not cleaned up, which usually causes no problem. If you need to clean up the metadata, you can manually execute the `tiup cluster prune` command.
Copy link
Contributor

@CharLotteiu CharLotteiu Apr 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the tiup cluster prune here be tiup dm prune? Because this file introduces the tiup dm prune command...

The Chinese version might need to be edited as well. PTAL @lucklove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

ran-huang
ran-huang reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-dm-prune.md Outdated

# tiup dm prune

When scaling in the cluster<!--(/tiup/tiup-component-dm-scale-in.md) -->, a small amount of metadata in etcd is not cleaned up, which usually causes no problem. If you need to clean up the metadata, you can manually execute the `tiup dm prune` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When scaling in the cluster<!--(/tiup/tiup-component-dm-scale-in.md) -->, a small amount of metadata in etcd is not cleaned up, which usually causes no problem. If you need to clean up the metadata, you can manually execute the `tiup dm prune` command.
When you scale in the cluster<!--(/tiup/tiup-component-dm-scale-in.md) -->, a small amount of metadata in etcd is not cleaned up, which usually causes no problem. If you need to clean up the metadata, you can manually execute the `tiup dm prune` command.

Note that when the subject in the subordinate clause is different from that of the main clause, you can't omit the former.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove
  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 405e442

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-chi-bot ti-chi-bot merged commit f0bb3e6 into pingcap:master Apr 15, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5308 to release-4.0
b62fb84 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5343

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 15, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5308 to release-5.0
513df1c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5344

ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 4 docs dm-prune/start/stop/reload (#5308) (#5343)
16491e8
ti-chi-bot pushed a commit that referenced this pull request Apr 15, 2021
@ti-srebot
tiup: add 4 docs dm-prune/start/stop/reload (#5308) (#5344)
0f4012b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu left review comments

@ran-huang ran-huang ran-huang left review comments

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Joyinqin @ran-huang @lucklove @ti-chi-bot @ti-srebot @CharLotteiu