Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiUP: add three documents for cluster import, scale-in, and dm list #5270

Merged
merged 22 commits into from
Apr 16, 2021
Merged

TiUP: add three documents for cluster import, scale-in, and dm list #5270

merged 22 commits into from
Apr 16, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 9, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai
Copy link
Collaborator Author

qiancai commented Apr 9, 2021

/WIP

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 9, 2021

/work-in-progress

@qiancai
Copy link
Collaborator Author

qiancai commented Apr 9, 2021

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 9, 2021
@qiancai qiancai changed the title TiUP: add two documents for cluster import and scale-in TiUP: add three documents for cluster import, scale-in, and dm list Apr 9, 2021
@Joyinqin Joyinqin mentioned this pull request Apr 12, 2021
Merged
11 tasks
This was referenced Apr 13, 2021
Merged
Merged
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 14, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/label require-LGT1
/cc @lucklove

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. labels Apr 14, 2021
@Joyinqin
Copy link
Contributor

/cc @TomShawn

@TomShawn
Copy link
Contributor

/rebase

TomShawn
TomShawn reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-cluster-import.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-import.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-import.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-import.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-import.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
@lucklove
Copy link
Member

Rest LGTM

qiancai and others added 7 commits April 15, 2021 17:13
@qiancai @TomShawn
Apply suggestions from code review
36de320 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai
Merge branch 'Translate-tiup-component-cluster-import' of https://git…
248d495 
…hub.com/qiancai/docs into Translate-tiup-component-cluster-import
@qiancai
Merge remote-tracking branch 'upstream/master' into Translate-tiup-co…
24b9cf2 
…mponent-cluster-import
@qiancai
Update tiup/tiup-component-cluster-scale-in.md
fa72f97
@qiancai
Update tiup-component-cluster-scale-in.md
91af73b
@qiancai @TomShawn
Update tiup/tiup-component-cluster-scale-in.md
bd46e29 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@qiancai @TomShawn
Update tiup/tiup-component-cluster-scale-in.md
c899189 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
TomShawn
TomShawn reviewed Apr 16, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
tiup/tiup-component-cluster-scale-in.md Outdated Show resolved Hide resolved
@qiancai @TomShawn
Apply suggestions from code review
6036663 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/lgtm

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6036663

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 9edbfac into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5270 to release-4.0
84c491e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5357

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@qiancai @ti-srebot
cherry pick pingcap#5270 to release-5.0
e3f4b20 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5358

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: add three documents for cluster import, scale-in, and dm list (#…
ec7bfc8 
…5270) (#5357)
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
TiUP: add three documents for cluster import, scale-in, and dm list (#…
531cd25 
…5270) (#5358)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lucklove lucklove Awaiting requested review from lucklove

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiancai @Joyinqin @TomShawn @lucklove @ti-chi-bot @ti-srebot