-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove json_unquote() from expressions-pushed-down.md #5564
Conversation
I removed JSON_UNQUOTE() because this expression is not currently pushed down. pingcap/tidb@721782d ``` MySQL [test]> explain analyze select count(*) from t2 where json_unquote(json_extract(j, '$[0]')) < 10; +-----------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+-----------+------+ | id | estRows | actRows | task | access object | execution info | operator info | memory | disk | +-----------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+-----------+------+ | StreamAgg_7 | 1.00 | 1 | root | | time:1.36ms, loops:2 | funcs:count(1)->Column#3 | 636 Bytes | N/A | | └─Selection_11 | 1.60 | 2 | root | | time:1.35ms, loops:2 | lt(cast(json_unquote(cast(json_extract(cast(test.t2.j), "$[0]")))), 10) | 628 Bytes | N/A | | └─TableReader_13 | 2.00 | 2 | root | | time:1.3ms, loops:3, cop_task: {num: 1, max: 1.24ms, proc_keys: 2, rpc_num: 1, rpc_time: 1.22ms, copr_cache_hit_ratio: 0.00} | data:TableRangeScan_12 | 219 Bytes | N/A | | └─TableRangeScan_12 | 2.00 | 2 | cop[tikv] | table:t2 | tikv_task:{time:0s, loops:1}, scan_detail: {total_process_keys: 2, total_keys: 4, rocksdb: {delete_skipped_count: 0, key_skipped_count: 2, block: {cache_hit_count: 0, read_count: 0, read_byte: 0 Bytes}}} | range:[0,+inf], keep order:false, stats:pseudo | N/A | N/A | +-----------------------------+---------+---------+-----------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+-------------------------------------------------------------------------+-----------+------+ 4 rows in set, 1 warning (0.002 sec) MySQL [test]> show warnings; +---------+------+----------------------------------------------------------------------------------------------+ | Level | Code | Message | +---------+------+----------------------------------------------------------------------------------------------+ | Warning | 1105 | Scalar function 'json_unquote'(signature: JsonUnquoteSig) can not be pushed to storage layer | +---------+------+----------------------------------------------------------------------------------------------+ 1 row in set (0.000 sec) ```
/label needs-cherry-pick-master |
/LGTM |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b79986f
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #5565 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to master in PR #5566 |
/remove-translation doing |
I removed JSON_UNQUOTE() because this expression is not currently pushed down.
pingcap/tidb@721782d
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?