-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: uncomment pushdown for JSONUnquote expression (#24504) #25721
expression: uncomment pushdown for JSONUnquote expression (#24504) #25721
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@bb7133 you're already a collaborator in bot's repo. |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
/merge |
@zhouqiang-cl: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@wshwsh12 ptal |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 36c36ee
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24504 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25721
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #24415
Problem Summary:
What is changed and how it works?
This PR tries to open the pushdown of
JSONUnquote
expression, by uncommenting it in the 'pushdown list'.Related changes
Check List
Tests
idc-jenkins-ci-tidb/integration-copr-test
"): https://github.com/tikv/copr-test/blob/master/push-down-test/sql/randgen/9_json.sqlRelease note
json_unquote()
to TiKV.