add global functions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <nolouch@gmail.com>
zimulala
reviewed
Jan 31, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
|
PTAL @zimulala |
rleungx
reviewed
Jan 31, 2019
| _globalS = _globalL.Sugar() | ||
| _globalMu sync.RWMutex | ||
| _globalL, _globalR = newStdLogger() | ||
| _globalS = _globalL.Sugar() |
There was a problem hiding this comment.
I'm not sure in our situation but keep supporting it.
zimulala
reviewed
Feb 1, 2019
|
Be remember that there is a problem when we use Mutex for GetLevel, see pingcap/tidb#7986 |
zimulala
reviewed
Feb 12, 2019
Signed-off-by: nolouch <nolouch@gmail.com>
zimulala
reviewed
Feb 13, 2019
| // Debug logs a message at DebugLevel. The message includes any fields passed | ||
| // at the log site, as well as any fields accumulated on the logger. | ||
| func Debug(msg string, fields ...zap.Field) { | ||
| L().WithOptions(zap.AddCallerSkip(1)).Debug(msg, fields...) |
There was a problem hiding this comment.
Could we add this option to the logger directly when creating the logger?
There was a problem hiding this comment.
Yes, we can. But I do not directly create the logger with this option because the user may use L(),S() without the export function.
rleungx
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com