Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: log format for schedule, scheduler, syncer, api #1423

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 30, 2019

What problem does this PR solve?

Format the log according to our RFC.

What is changed and how it works?

This PR is going to do the log format for schedule, scheduler, syncer, and api packages.

Check List

Tests

  • Unit test

@rleungx rleungx added type/enhancement The issue or PR belongs to an enhancement. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 30, 2019
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #1423 into master will increase coverage by 0.09%.
The diff coverage is 56.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
+ Coverage   67.67%   67.76%   +0.09%     
==========================================
  Files         158      158              
  Lines       15006    15016      +10     
==========================================
+ Hits        10155    10176      +21     
+ Misses       3918     3917       -1     
+ Partials      933      923      -10
Impacted Files Coverage Δ
server/schedule/filters.go 76.3% <ø> (-0.28%) ⬇️
server/api/util.go 61.4% <0%> (ø) ⬆️
server/schedulers/shuffle_hot_region.go 64.1% <0%> (-6.42%) ⬇️
server/schedulers/shuffle_region.go 75.92% <0%> (ø) ⬆️
server/schedule/operator.go 89.12% <0%> (ø) ⬆️
server/api/member.go 61.6% <0%> (ø) ⬆️
server/schedulers/adjacent_region.go 74.56% <0%> (ø) ⬆️
server/schedule/mockcluster.go 83.85% <0%> (ø) ⬆️
server/schedulers/base_scheduler.go 63.15% <0%> (ø) ⬆️
server/schedulers/hot_region.go 79.45% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db4a56...dc5addd. Read the comment docs.

@disksing
Copy link
Contributor

Does it need to be merged after #1422?

server/schedulers/shuffle_hot_region.go Outdated Show resolved Hide resolved
server/schedulers/hot_region.go Outdated Show resolved Hide resolved
server/schedulers/balance_region.go Outdated Show resolved Hide resolved
server/schedulers/balance_region.go Outdated Show resolved Hide resolved
server/schedulers/balance_leader.go Outdated Show resolved Hide resolved
server/schedule/operator.go Outdated Show resolved Hide resolved
server/schedule/operator.go Outdated Show resolved Hide resolved
server/schedule/operator.go Outdated Show resolved Hide resolved
server/schedule/operator_controller.go Outdated Show resolved Hide resolved
server/schedule/replica_checker.go Outdated Show resolved Hide resolved
@rleungx
Copy link
Member Author

rleungx commented Jan 31, 2019

@disksing Yes. And this PR is still working in progress. Also, it needs to wait for pingcap/log#2 merging.

@disksing
Copy link
Contributor

LGTM except for the inconsistent naming.

Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx rleungx removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2019
Signed-off-by: rleungx <rleungx@gmail.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch merged commit 41f5261 into tikv:master Feb 15, 2019
@nolouch nolouch added the component/log Log. label Feb 18, 2019
nolouch pushed a commit to nolouch/pd that referenced this pull request Jul 10, 2019
* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Jul 17, 2019
* *:Start swithing to the zap logger (#1422)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for schedule, scheduler, syncer, api (#1423)

* log format for schedule, scheduler, syncer, api

Signed-off-by: rleungx <rleungx@gmail.com>

* pdctl, api: support hex format keys (#1309)

pdctl, api: support hex format keys

Signed-off-by: disksing <i@disksing.com>

* *: log format for tools, client, pkg, table (#1424)

* log format for tools, client, pkg, table, simulator

Signed-off-by: rleungx <rleungx@gmail.com>

* *: log format for server (#1431)

* *: log format for server

Signed-off-by: nolouch <nolouch@gmail.com>

* *: log format for logutil, server/core (#1438)

* *: log format for logutil,server/core

* *: improve some logs (#1516)

* improve some logs

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* log: do not add stack to error log (#1532)

* pkg, tools: improve the log message (#1636)

* pkg,tools: improve the log message

Signed-off-by: nolouch <nolouch@gmail.com>

* core: use hex format for region meta key (#1627)

Signed-off-by: Ryan Leung <rleungx@gmail.com>=

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>

* address comments

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants