-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdctl, api: support hex format keys #1309
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
disksing
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Nov 6, 2018
disksing
added
area/pdctl
component/api
HTTP API.
and removed
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
labels
Nov 6, 2018
nolouch
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
rleungx
approved these changes
Nov 6, 2018
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Nov 12, 2018
pdctl, api: support hex format keys Signed-off-by: disksing <i@disksing.com>
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
pdctl, api: support hex format keys Signed-off-by: disksing <i@disksing.com>
youjiali1995
pushed a commit
that referenced
this pull request
Jul 17, 2019
* *:Start swithing to the zap logger (#1422) Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for schedule, scheduler, syncer, api (#1423) * log format for schedule, scheduler, syncer, api Signed-off-by: rleungx <rleungx@gmail.com> * pdctl, api: support hex format keys (#1309) pdctl, api: support hex format keys Signed-off-by: disksing <i@disksing.com> * *: log format for tools, client, pkg, table (#1424) * log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com> * *: log format for server (#1431) * *: log format for server Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for logutil, server/core (#1438) * *: log format for logutil,server/core * *: improve some logs (#1516) * improve some logs Signed-off-by: Ryan Leung <rleungx@gmail.com> * log: do not add stack to error log (#1532) * pkg, tools: improve the log message (#1636) * pkg,tools: improve the log message Signed-off-by: nolouch <nolouch@gmail.com> * core: use hex format for region meta key (#1627) Signed-off-by: Ryan Leung <rleungx@gmail.com>= * address comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the variety of key formats used in different Ti projects. We finally decided to use the hex format everywhere.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes