-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: do not add stack to error log #1532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1532 +/- ##
==========================================
- Coverage 67.71% 67.53% -0.18%
==========================================
Files 158 158
Lines 15649 15649
==========================================
- Hits 10596 10568 -28
- Misses 4097 4113 +16
- Partials 956 968 +12
Continue to review full report at Codecov.
|
LGTM |
rleungx
approved these changes
May 8, 2019
disksing
approved these changes
May 9, 2019
nolouch
added a commit
that referenced
this pull request
May 23, 2019
* tiny clean up code (#1526) Signed-off-by: Ryan Leung <rleungx@gmail.com> * config: enable use region storage by default (#1524) * config: default enable use region storage * schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522) Signed-off-by: nolouch <nolouch@gmail.com> * log: do not add stack to error log (#1532) * *: replace gofail with pingcap/failpoint (#1534) * *: replace gofail with pingcap/failpoint Signed-off-by: disksing <i@disksing.com> * fix typo Signed-off-by: disksing <i@disksing.com> * fix typo Signed-off-by: disksing <i@disksing.com> * Update server/cluster_test.go Co-Authored-By: Lonng <chris@lonng.org> * Update server/tso.go Co-Authored-By: Lonng <chris@lonng.org> * Update server/tso.go Co-Authored-By: Lonng <chris@lonng.org> * check enable failpoint result Signed-off-by: disksing <i@disksing.com> * Update server/cluster.go Co-Authored-By: Lonng <chris@lonng.org> * server: set timeout for MoveLeader (#1533) * server: set timeout for MoveLeader Signed-off-by: disksing <i@disksing.com> * client, server: add ScanRegions gRPC protocol support (#1535) * client, server: support ScanRegions gRPC protocol Signed-off-by: disksing <i@disksing.com> * schedule: actively push operator (#1536) * schedule: actively push operator Signed-off-by: nolouch <nolouch@gmail.com> * *: update some dead links (#1543) * update links Signed-off-by: Ryan Leung <rleungx@gmail.com> * Add windows build script (#1540) Signed-off-by: Ana Hobden <operator@hoverbear.org> * fix operator timeout metrics (#1541) Signed-off-by: Ryan Leung <rleungx@gmail.com> * *:Rollback config in store when kv.persist failed (#1476) * tests: independent region sync test (#1545) * tests: independent syncer region test Signed-off-by: nolouch <nolouch@gmail.com> * schedule: operator limit for stores (#1474) * add store limit for scheduling Signed-off-by: Ryan Leung <rleungx@gmail.com> * statistic: add the statistic of flow (#1548) * store_statistic: add the statistic of flow Signed-off-by: nolouch <nolouch@gmail.com>
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
youjiali1995
pushed a commit
that referenced
this pull request
Jul 17, 2019
* *:Start swithing to the zap logger (#1422) Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for schedule, scheduler, syncer, api (#1423) * log format for schedule, scheduler, syncer, api Signed-off-by: rleungx <rleungx@gmail.com> * pdctl, api: support hex format keys (#1309) pdctl, api: support hex format keys Signed-off-by: disksing <i@disksing.com> * *: log format for tools, client, pkg, table (#1424) * log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com> * *: log format for server (#1431) * *: log format for server Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for logutil, server/core (#1438) * *: log format for logutil,server/core * *: improve some logs (#1516) * improve some logs Signed-off-by: Ryan Leung <rleungx@gmail.com> * log: do not add stack to error log (#1532) * pkg, tools: improve the log message (#1636) * pkg,tools: improve the log message Signed-off-by: nolouch <nolouch@gmail.com> * core: use hex format for region meta key (#1627) Signed-off-by: Ryan Leung <rleungx@gmail.com>= * address comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #1523
The stack trace of error level is not required, we can add a field if we need it.
What is changed and how it works?
change the stack enable level.
Check List
Tests