*: log format for tools, client, pkg, table #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #1424 +/- ##
=========================================
- Coverage 67.74% 67.65% -0.1%
=========================================
Files 158 158
Lines 15048 15076 +28
=========================================
+ Hits 10194 10199 +5
- Misses 3924 3951 +27
+ Partials 930 926 -4
Continue to review full report at Codecov.
|
disksing
approved these changes
Feb 11, 2019
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
force-pushed
the
update-log-format
branch
from
f804f91
to
f8a67cb
Compare
Signed-off-by: rleungx <rleungx@gmail.com>
rleungx
force-pushed
the
update-log-format
branch
from
f8a67cb
to
c569c8e
Compare
rleungx
removed
the
do-not-merge/work-in-progress
nolouch
approved these changes
Feb 18, 2019
|
/rebuild |
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
* log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com>
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
* log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com>
nolouch
pushed a commit
to nolouch/pd
that referenced
this pull request
Jul 10, 2019
* log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com>
youjiali1995
pushed a commit
that referenced
this pull request
Jul 17, 2019
* *:Start swithing to the zap logger (#1422) Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for schedule, scheduler, syncer, api (#1423) * log format for schedule, scheduler, syncer, api Signed-off-by: rleungx <rleungx@gmail.com> * pdctl, api: support hex format keys (#1309) pdctl, api: support hex format keys Signed-off-by: disksing <i@disksing.com> * *: log format for tools, client, pkg, table (#1424) * log format for tools, client, pkg, table, simulator Signed-off-by: rleungx <rleungx@gmail.com> * *: log format for server (#1431) * *: log format for server Signed-off-by: nolouch <nolouch@gmail.com> * *: log format for logutil, server/core (#1438) * *: log format for logutil,server/core * *: improve some logs (#1516) * improve some logs Signed-off-by: Ryan Leung <rleungx@gmail.com> * log: do not add stack to error log (#1532) * pkg, tools: improve the log message (#1636) * pkg,tools: improve the log message Signed-off-by: nolouch <nolouch@gmail.com> * core: use hex format for region meta key (#1627) Signed-off-by: Ryan Leung <rleungx@gmail.com>= * address comments Signed-off-by: nolouch <nolouch@gmail.com> * address comments Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Format the log according to our RFC.
What is changed and how it works?
This PR is going to do the log format for tools, client, pkg, and table packages.
And it still works in progress. Do not review it now.
Check List
Tests