*: refine split region syntax add split partition table region syntax. (

#561) (#663)
pingcap · Dec 5, 2019 · 91f36bd · 91f36bd
1 parent 62bbf32
commit 91f36bd
Show file tree

Hide file tree

Showing 5 changed files with 6,571 additions and 6,441 deletions.
diff --git a/ast/dml.go b/ast/dml.go
@@ -2438,8 +2438,11 @@ func (n *FrameBound) Accept(v Visitor) (Node, bool) {
 type SplitRegionStmt struct {
 	dmlNode
 
-	Table     *TableName
-	IndexName model.CIStr
+	Table          *TableName
+	IndexName      model.CIStr
+	PartitionNames []model.CIStr
+
+	SplitSyntaxOpt *SplitSyntaxOption
 
 	SplitOpt *SplitOption
 }
@@ -2451,11 +2454,39 @@ type SplitOption struct {
 	ValueLists [][]ExprNode
 }
 
+type SplitSyntaxOption struct {
+	HasRegionFor bool
+	HasPartition bool
+}
+
 func (n *SplitRegionStmt) Restore(ctx *RestoreCtx) error {
-	ctx.WriteKeyWord("SPLIT TABLE ")
+	ctx.WriteKeyWord("SPLIT ")
+	if n.SplitSyntaxOpt != nil {
+		if n.SplitSyntaxOpt.HasRegionFor {
+			ctx.WriteKeyWord("REGION FOR ")
+		}
+		if n.SplitSyntaxOpt.HasPartition {
+			ctx.WriteKeyWord("PARTITION ")
+
+		}
+	}
+	ctx.WriteKeyWord("TABLE ")
+
 	if err := n.Table.Restore(ctx); err != nil {
 		return errors.Annotate(err, "An error occurred while restore SplitIndexRegionStmt.Table")
 	}
+	if len(n.PartitionNames) > 0 {
+		ctx.WriteKeyWord(" PARTITION")
+		ctx.WritePlain("(")
+		for i, v := range n.PartitionNames {
+			if i != 0 {
+				ctx.WritePlain(", ")
+			}
+			ctx.WriteName(v.String())
+		}
+		ctx.WritePlain(")")
+	}
+
 	if len(n.IndexName.L) > 0 {
 		ctx.WriteKeyWord(" INDEX ")
 		ctx.WriteName(n.IndexName.String())

diff --git a/misc.go b/misc.go
@@ -437,6 +437,7 @@ var tokenMap = map[string]int{
 	"REFERENCES":               references,
 	"REGEXP":                   regexpKwd,
 	"REGIONS":                  regions,
+	"REGION":                   region,
 	"RELOAD":                   reload,
 	"RENAME":                   rename,
 	"REPEAT":                   repeat,