Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: refine split region syntax add split partition table region syntax (#561) #663

Merged
merged 1 commit into from
Dec 5, 2019
Merged

*: refine split region syntax add split partition table region syntax (#561) #663

merged 1 commit into from
Dec 5, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Dec 5, 2019 •
edited
Loading

What problem does this PR solve?

cherry-pick #561

@crazycs520 crazycs520 changed the title *: refine split region syntax add split partition table region syntax… *: refine split region syntax add split partition table region syntax (#561) Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019 •
edited
Loading

Codecov Report

Merging #663 into release-3.0 will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0     #663      +/-   ##
===============================================
- Coverage        63.89%   63.86%   -0.03%     
===============================================
  Files               31       31              
  Lines            10831    10861      +30     
===============================================
+ Hits              6920     6936      +16     
- Misses            3502     3516      +14     
  Partials           409      409
Impacted Files Coverage Δ
parser.go 86.46% <ø> (+0.05%) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/dml.go 39.98% <0%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62bbf32...786232a. Read the comment docs.

@crazycs520 crazycs520 mentioned this pull request Dec 5, 2019
Merged
zimulala
zimulala reviewed Dec 5, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 91f36bd into pingcap:release-3.0 Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crazycs520 @bb7133 @zimulala