parser: implement Restore for TableOptimizerHint #151
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impletment
Restore
and unit test forTableOptimizerHint
.Issue: pingcap/tidb#8532
Here is a problem that should be resolved before moving on to
SelectStmt
. TheSelectField
s of the following two queries are different:select /*+ TIDB_SMJ(t1) */ * from t1 join t2
select /*+ TIDB_SMJ(`t1`) */ * from t1 join t2
The only difference is
SelectField.Offset
, which will count the backquotes put byRestore
. For this PR we can wrap identifiers in the source SQL text with backquotes, but there are hundreds ofselect
test cases ofSelectStmt
and some shall not be handled this way. So any suggestion?