-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: implement Restore for SelectStmt #153
Conversation
@kennytm You can free to choose one, I implement it only because |
@kennytm @leoppro Almost all the Lines 1430 to 1447 in d8e164f
If we restore a statement like SELECT .78 , output would become SELECT 0.78 , so the MyDeciaml 's digitsInt will change from 0 to 1 , DeepEquals will fail.
Besides |
could you handle this by updating |
this attr could not update now ... |
@leoppro PTAL, use another way to deal with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kennytm PTAL |
@kennytm Comment handled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
implement Restore for
SelectStmt
implement Restore for
UnionSelectList
implement Restore for
SubqueryExpr
implement Restore for
CompareSubqueryExpr
implement Restore for
TableOptimizerHint
Add
SelectStmt
test case, the rest would be add soon, too many test case.Issue: pingcap/tidb#8532