ast: add set default role #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Mar 29, 2019
ast/misc.go
Outdated
| case SetRoleAll: | ||
| ctx.WriteKeyWord(" ALL") | ||
| default: | ||
| ctx.WriteKeyWord("") |
There was a problem hiding this comment.
Suggested change
| ctx.WriteKeyWord("") |
No need to write nothing 🙂
|
Please address the comment, @imtbkcat . |
kennytm
previously approved these changes
Apr 4, 2019
|
@kennytm this pr need an approve 😊 |
|
Please resolve the merge conflict 🙂 |
added 2 commits
April 9, 2019 11:23
|
@kennytm conflict has been reslove, but approve was dismissed. Please approve again and merge this pr. |
jackysp
approved these changes
Apr 9, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support
SET DEFAULT ROLEto set default active roles for user.What is changed and how it works?
Add
SetDefaultRoleStmtforastwhich contain information forexecutorto do next step.Check List
Tests
Code changes
Side effects