privilege, executor: support SET DEFAULT ROLE
#9949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9949 +/- ##
================================================
- Coverage 77.9619% 77.8868% -0.0751%
================================================
Files 405 405
Lines 82244 82381 +137
================================================
+ Hits 64119 64164 +45
- Misses 13392 13456 +64
- Partials 4733 4761 +28 |
|
/run-all-tests |
|
parser pr: pingcap/parser#266 |
tiancaiamao
reviewed
Apr 8, 2019
|
LGTM |
jackysp
reviewed
Apr 17, 2019
executor/simple.go
Outdated
| } | ||
| e.done = true | ||
| return err | ||
| } | ||
|
|
||
| func (e *SimpleExec) setDefaultRoleNone(s *ast.SetDefaultRoleStmt) error { | ||
| if _, err := e.ctx.(sqlexec.SQLExecutor).Execute(context.Background(), "begin"); err != nil { |
There was a problem hiding this comment.
could we avoid repeatedly using the interface assert?
added 13 commits
April 17, 2019 13:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support
SET DEFAULT ROLEgramma.See https://dev.mysql.com/doc/refman/8.0/en/set-default-role.html for detail
What is changed and how it works?
When
SET DEFAULT ROLEfor some users, we clear their data inmysql.default_rolesand insert new default role information intomysql.default_roles.Things need to be pay attention is handling error when insert transaction failed.
Check List
Tests
Code changes
Side effects