parser: fix hint parsing in select /*+ max_execution_time */ 1
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 50.51% 50.51%
=======================================
Files 31 31
Lines 6909 6909
=======================================
Hits 3490 3490
Misses 3060 3060
Partials 359 359
Continue to review full report at Codecov.
|
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Jul 1, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 1, 2019
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Jul 2, 2019
jackysp
pushed a commit
that referenced
this pull request
Jul 2, 2019
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In this query,
SELECT /*+ MAX_EXECUTION_TIME(1000) */ 1, theMAX_EXECUTION_TIMEhint is not saved tost.TableHintspingcap/tidb#10955 is caused by this bug.
What is changed and how it works?
Move this line
to
SelectStmtBasicwill address the problem.Check List
Tests
Related changes