session,parser: make MAX_EXECUTION_TIME sql hint and global variable work #10963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
type/compatibility
type/bugfix
…work update go.mod to use the latest parser which fix the sql hint for MAX_EXECUTION_TIME put max_execution_time into the auto load system variable list so it's correctly initialized Fix issue pingcap#10955
tiancaiamao
force-pushed
the
load-max-execution-time
branch
from
3369a84 to
7428f03
Compare
|
|
Codecov Report
@@ Coverage Diff @@
## master #10963 +/- ##
================================================
- Coverage 80.9317% 80.9157% -0.0161%
================================================
Files 418 418
Lines 89253 89220 -33
================================================
- Hits 72234 72193 -41
- Misses 11785 11789 +4
- Partials 5234 5238 +4 |
|
/run-all-tests |
crazycs520
reviewed
Jun 28, 2019
| @@ -43,7 +43,7 @@ require ( | |||
| github.com/pingcap/goleveldb v0.0.0-20171020122428-b9ff6c35079e | |||
| github.com/pingcap/kvproto v0.0.0-20190619024611-a4759dfe3753 | |||
| github.com/pingcap/log v0.0.0-20190307075452-bd41d9273596 | |||
| github.com/pingcap/parser v0.0.0-20190613082312-d2cf6071823d | |||
| github.com/pingcap/parser v0.0.0-20190627064259-e9c42442aa72 | |||
There was a problem hiding this comment.
Why need to change parser?
There was a problem hiding this comment.
To include this fix pingcap/parser#366
The SQL hint is not successful parsed in select /*+ MAX_EXECUTION_TIME(1000) */ SLEEP(5);
@crazycs520
This was referenced Jul 1, 2019
winkyao
pushed a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10955
What is changed and how it works?
update go.mod to use the latest parser which fixes the SQL hint for MAX_EXECUTION_TIME
put
max_execution_timeinto the auto loaded system variable list so it's correctly initializedCheck List
Tests
Related changes