-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support cast as double #399
Conversation
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 32 32
Lines 7450 7450
=======================================
Hits 5232 5232
Misses 1703 1703
Partials 515 515
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a test case showing that CAST(x AS DOUBLE)
is now a valid expression.
Rest LGTM.
CAST(x AS FLOAT)
, CAST(x AS FLOAT(p))
and CAST(x AS REAL)
are also added in 8.0.17, would you mind at least supporting CAST(x AS FLOAT)
in this or a future PR? Thanks.
d2590dd
to
3291f08
Compare
3291f08
to
e79dc55
Compare
UPDATE. PTAL @kennytm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Related TiDB PR: pingcap/tidb#11443
Support
cast(xxx as double)
.Mysql support the parser in 8.0.17.
https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html