Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support cast as double #11443

Merged
merged 6 commits into from
Jul 29, 2019
Merged

parser: support cast as double #11443

merged 6 commits into from
Jul 29, 2019

Conversation

wshwsh12
Copy link
Contributor

What problem does this PR solve?

Support cast(xxx as double).
Mysql support the parser in 8.0.17.
https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html

@wshwsh12 wshwsh12 mentioned this pull request Jul 25, 2019
Merged
@winoros
Copy link
Member

winoros commented Jul 25, 2019

This pr only updates the parser?

@wshwsh12
Copy link
Contributor Author

This pr only updates the parser?

Yes

@codecov
Copy link

codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #11443 into master will decrease coverage by 0.3244%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #11443        +/-   ##
================================================
- Coverage   81.6838%   81.3594%   -0.3245%     
================================================
  Files           424        424                
  Lines         92061      90818      -1243     
================================================
- Hits          75199      73889      -1310     
- Misses        11553      11616        +63     
- Partials       5309       5313         +4

@wshwsh12
Copy link
Contributor Author

/run-all-tests

@wshwsh12 wshwsh12 requested a review from XuHuaiyu July 26, 2019 10:52
zz-jason
zz-jason reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT1 Indicates that a PR has LGTM 1. type/new-feature labels Jul 26, 2019
XuHuaiyu
XuHuaiyu approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

@wshwsh12 merge failed.

@zz-jason zz-jason merged commit 1ae5e4c into pingcap:master Jul 29, 2019
@zz-jason
Copy link
Member

@wshwsh12 Please update the document as well.

@wshwsh12
Copy link
Contributor Author

@wshwsh12 Please update the document as well.

OK

@wshwsh12 wshwsh12 deleted the support_cast_as_double branch July 29, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@lysu lysu Awaiting requested review from lysu

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression component/parser status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wshwsh12 @winoros @sre-bot @zz-jason @XuHuaiyu