Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Fix CHECK PARTITION syntax #457

Merged
merged 7 commits into from
Aug 16, 2019
Merged

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

to #435 . Support CHECK PARTITION Syntax.

What is changed and how it works?

  1. Add related parser rule in parser.y
  2. Add a helper struct AllOrPartitionNames and complete Restore method for struct AlterTableSpec
  3. Add related tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

@codecov
Copy link

codecov bot commented Aug 11, 2019

Codecov Report

Merging #457 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage    71.4%   71.44%   +0.03%     
==========================================
  Files          32       32              
  Lines        7639     7648       +9     
==========================================
+ Hits         5455     5464       +9     
  Misses       1665     1665              
  Partials      519      519
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/ddl.go 79.85% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15ebd4e...b930591. Read the comment docs.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

parser.y Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

@spongedu Due to our negligence, it seems there are some conflicts with the PR. You can pause updating until some reusable data structures are developed.

@spongedu
Copy link
Contributor Author

@spongedu Due to our negligence, it seems there are some conflicts with the PR. You can pause updating until some reusable data structures are developed.

OK.

@spongedu
Copy link
Contributor Author

@leoppro @tangenta PTAL

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ast/ddl.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the status/LGT2 LGT2 label Aug 16, 2019
@zier-one zier-one merged commit 151a748 into pingcap:master Aug 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants