Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ALTER TABLE REBUILD PARTITION syntax #469

Merged
merged 12 commits into from
Aug 16, 2019

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

for #448 , support ALTER TABLE REBUILD PARTITION syntax in Parser

What is changed and how it works?

  1. Add related parser rule in parser.y
  2. Complete Restore method for struct AlterTableSpec
  3. Add related tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #469 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   71.44%   71.45%   +<.01%     
==========================================
  Files          32       32              
  Lines        7648     7650       +2     
==========================================
+ Hits         5464     5466       +2     
  Misses       1665     1665              
  Partials      519      519
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 79.88% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 151a748...bc38b72. Read the comment docs.

@kennytm
Copy link
Contributor

kennytm commented Aug 13, 2019

Is this blocked by #453 (same situation as #457)?

@spongedu
Copy link
Contributor Author

Is this blocked by #453 (same situation as #457)?

@kennytm yep, seems so. All these issues require some structure like AllOrPartitionList

@spongedu
Copy link
Contributor Author

@kennytm PTAL

parser.y Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
@spongedu
Copy link
Contributor Author

@leoppro PTAL

Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the status/LGT1 LGT1 label Aug 16, 2019
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 16, 2019
@zier-one
Copy link
Contributor

resolve the conflicts please

@spongedu
Copy link
Contributor Author

resolve the conflicts please

Done

@zier-one zier-one merged commit b327e72 into pingcap:master Aug 16, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants