add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION #453

huaouo · 2019-08-10T12:18:28Z

What problem does this PR solve?

MySQL Syntax:

alter_specification:
...
  | DISCARD PARTITION {partition_names | ALL} TABLESPACE
  | IMPORT PARTITION {partition_names | ALL} TABLESPACE
  | TRUNCATE PARTITION {partition_names | ALL}
  | OPTIMIZE PARTITION {partition_names | ALL}
  | REPAIR PARTITION {partition_names | ALL}
...

Add TRUNCATE PARTITION ALL clause.

What is changed and how it works?

Update ast/ddl.go, add some new AlterTableSpec types and modify Restore
Update parser.y.
Add more tests.

Check List

Tests

Unit test

CLAassistant · 2019-08-10T12:18:34Z

All committers have signed the CLA.

kennytm

LGTM

parser_test.go

codecov · 2019-08-10T14:26:37Z

Codecov Report

Merging #453 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   71.24%   71.29%   +0.05%     
==========================================
  Files          32       32              
  Lines        7594     7587       -7     
==========================================
- Hits         5410     5409       -1     
+ Misses       1665     1662       -3     
+ Partials      519      516       -3

Impacted Files	Coverage Δ
parser.go	`70.58% <ø> (ø)`	⬆️
misc.go	`96.42% <ø> (ø)`	⬆️
ast/ddl.go	`79.67% <100%> (+0.56%)`	⬆️
ast/misc.go	`73.56% <0%> (-0.5%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba2994...27050dc. Read the comment docs.

kennytm · 2019-08-10T17:57:33Z

PTAL @tangenta

ast/ddl.go

parser.y

…PAIR PARTITION

spongedu · 2019-08-13T15:51:15Z

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

huaouo · 2019-08-13T16:13:50Z

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

I'm sorry to bother you at midnight, but on my machine, there seems no such a problem. So wired.

➜  Workspace git clone https://github.com/huaouo/parser
Cloning into 'parser'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 2162 (delta 18), reused 23 (delta 13), pack-reused 2133
Receiving objects: 100% (2162/2162), 13.57 MiB | 279.00 KiB/s, done.
Resolving deltas: 100% (1603/1603), done.
➜  Workspace cd parser                                 
➜  parser git:(master) make test
gofmt (simplify)
sh test.sh
ok  	github.com/pingcap/parser	2.361s	coverage: 66.6% of statements in ./...
ok  	github.com/pingcap/parser/ast	1.422s	coverage: 44.8% of statements in ./...
ok  	github.com/pingcap/parser/auth	1.040s	coverage: 1.4% of statements in ./... [no tests to run]
ok  	github.com/pingcap/parser/charset	1.042s	coverage: 2.0% of statements in ./...
ok  	github.com/pingcap/parser/format	1.042s	coverage: 2.6% of statements in ./...
?   	github.com/pingcap/parser/goyacc	[no test files]
ok  	github.com/pingcap/parser/model	1.046s	coverage: 3.6% of statements in ./...
ok  	github.com/pingcap/parser/mysql	1.043s	coverage: 1.8% of statements in ./...
ok  	github.com/pingcap/parser/opcode	1.040s	coverage: 1.5% of statements in ./...
ok  	github.com/pingcap/parser/terror	1.040s	coverage: 2.4% of statements in ./...
ok  	github.com/pingcap/parser/types	1.048s	coverage: 7.3% of statements in ./...
➜  parser git:(master) git log -1 | head
commit ef08923e4d8e62fb1efba66716397bfe99fd8910
Author: Zhenhua Yang <huaouo@qq.com>
Date:   Tue Aug 13 23:18:18 2019 +0800

    add NO_WRITE_TO_BINLOG option for ALTER TABLE OPTIMIZE PARTITION & REPAIR PARTITION

spongedu · 2019-08-13T16:25:45Z

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

I'm sorry to bother you at midnight, but on my machine, there seems no such a problem. So wired.

➜  Workspace git clone https://github.com/huaouo/parser
Cloning into 'parser'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 2162 (delta 18), reused 23 (delta 13), pack-reused 2133
Receiving objects: 100% (2162/2162), 13.57 MiB | 279.00 KiB/s, done.
Resolving deltas: 100% (1603/1603), done.
➜  Workspace cd parser                                 
➜  parser git:(master) make test
gofmt (simplify)
sh test.sh
ok  	github.com/pingcap/parser	2.361s	coverage: 66.6% of statements in ./...
ok  	github.com/pingcap/parser/ast	1.422s	coverage: 44.8% of statements in ./...
ok  	github.com/pingcap/parser/auth	1.040s	coverage: 1.4% of statements in ./... [no tests to run]
ok  	github.com/pingcap/parser/charset	1.042s	coverage: 2.0% of statements in ./...
ok  	github.com/pingcap/parser/format	1.042s	coverage: 2.6% of statements in ./...
?   	github.com/pingcap/parser/goyacc	[no test files]
ok  	github.com/pingcap/parser/model	1.046s	coverage: 3.6% of statements in ./...
ok  	github.com/pingcap/parser/mysql	1.043s	coverage: 1.8% of statements in ./...
ok  	github.com/pingcap/parser/opcode	1.040s	coverage: 1.5% of statements in ./...
ok  	github.com/pingcap/parser/terror	1.040s	coverage: 2.4% of statements in ./...
ok  	github.com/pingcap/parser/types	1.048s	coverage: 7.3% of statements in ./...
➜  parser git:(master) git log -1 | head
commit ef08923e4d8e62fb1efba66716397bfe99fd8910
Author: Zhenhua Yang <huaouo@qq.com>
Date:   Tue Aug 13 23:18:18 2019 +0800

    add NO_WRITE_TO_BINLOG option for ALTER TABLE OPTIMIZE PARTITION & REPAIR PARTITION

Try to delete parser.go and execute make again?

spongedu

LGTM

spongedu · 2019-08-14T05:06:49Z

@huaouo Please resolve conflicts :)

parser.y

Co-Authored-By: leoppro <i@leop.pro>

zier-one · 2019-08-14T07:29:19Z

LGTM

zier-one · 2019-08-14T07:29:39Z

@kennytm PTAL

huaouo · 2019-08-14T07:35:21Z

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

zier-one · 2019-08-14T09:02:20Z

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

huaouo · 2019-08-14T09:41:56Z

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

But according to MySQL's parser file, it also requires an opt_no_write_to_binlog option, same as ANALYZE TABLE stmt.

kennytm

LGTM

zier-one · 2019-08-15T01:57:09Z

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

But according to MySQL's parser file, it also requires an opt_no_write_to_binlog option, same as ANALYZE TABLE stmt.

Oh, I had a wrong understanding of your comment. We need to fix it.

…ingcap#453)

add support for TRUNCATE PARTITION ALL

aa7cad5

kennytm reviewed Aug 10, 2019

View reviewed changes

parser_test.go Show resolved Hide resolved

kennytm added contribution status/LGT1 LGT1 labels Aug 10, 2019

add parse failure tests

088a2d9

spongedu suggested changes Aug 11, 2019

View reviewed changes

ast/ddl.go Outdated Show resolved Hide resolved

zier-one mentioned this pull request Aug 12, 2019

Improve parser compatibility pingcap/tidb#11486

Closed

58 tasks

use OnAllPartitions flag instead of an operation type

d33773c

zier-one reviewed Aug 12, 2019

View reviewed changes

parser.y Outdated Show resolved Hide resolved

zier-one removed the status/LGT1 LGT1 label Aug 12, 2019

refactor to use AllOrPartitionNameList

2946579

huaouo added 2 commits August 13, 2019 00:06

add support for OPTIMIZE PARTITION

72f7049

add support for REPAIR PARTITION

e90203f

spongedu suggested changes Aug 13, 2019

View reviewed changes

parser.y Outdated Show resolved Hide resolved

parser.y Outdated Show resolved Hide resolved

add NO_WRITE_TO_BINLOG option for ALTER TABLE OPTIMIZE PARTITION & RE…

ef08923

…PAIR PARTITION

kennytm mentioned this pull request Aug 13, 2019

Support ALTER TABLE REBUILD PARTITION syntax #469

Merged

resolve shift/reduce confict

447f3aa

spongedu previously approved these changes Aug 14, 2019

View reviewed changes

Merge branch 'master' of https://github.com/pingcap/parser

a7fde12

huaouo dismissed spongedu’s stale review via a7fde12 August 14, 2019 05:23

zier-one reviewed Aug 14, 2019

View reviewed changes

parser.y Outdated Show resolved Hide resolved

huaouo added 2 commits August 14, 2019 15:08

refactor to remove ast.AllOrPartitionNames

5b34e68

add support for IMPORT/DISCARD PARTITION TABLESPACE

0a12fbf

zier-one reviewed Aug 14, 2019

View reviewed changes

parser.y Outdated Show resolved Hide resolved

Update parser.y

2c839b9

Co-Authored-By: leoppro <i@leop.pro>

zier-one added the status/LGT1 LGT1 label Aug 14, 2019

kennytm reviewed Aug 14, 2019

View reviewed changes

kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 14, 2019

merge master

27050dc

zier-one approved these changes Aug 15, 2019

View reviewed changes

zier-one merged commit 15ebd4e into pingcap:master Aug 15, 2019

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION (p…

e6b3996

…ingcap#453)

lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION (p…

2eccb3a

…ingcap#453)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION #453

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION #453

huaouo commented Aug 10, 2019 •

edited

Loading

CLAassistant commented Aug 10, 2019 •

edited

Loading

kennytm left a comment

codecov bot commented Aug 10, 2019 •

edited

Loading

kennytm commented Aug 10, 2019

spongedu commented Aug 13, 2019

huaouo commented Aug 13, 2019

spongedu commented Aug 13, 2019

spongedu left a comment

spongedu commented Aug 14, 2019

zier-one commented Aug 14, 2019

zier-one commented Aug 14, 2019

huaouo commented Aug 14, 2019

zier-one commented Aug 14, 2019

huaouo commented Aug 14, 2019

kennytm left a comment

zier-one commented Aug 15, 2019

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION #453

add support for [TRUNCATE|DISCARD|IMPORT|OPTIMIZE|REPAIR] PARTITION #453

Conversation

huaouo commented Aug 10, 2019 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

CLAassistant commented Aug 10, 2019 • edited Loading

kennytm left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 10, 2019 • edited Loading

Codecov Report

kennytm commented Aug 10, 2019

spongedu commented Aug 13, 2019

huaouo commented Aug 13, 2019

spongedu commented Aug 13, 2019

spongedu left a comment

Choose a reason for hiding this comment

spongedu commented Aug 14, 2019

zier-one commented Aug 14, 2019

zier-one commented Aug 14, 2019

huaouo commented Aug 14, 2019

zier-one commented Aug 14, 2019

huaouo commented Aug 14, 2019

kennytm left a comment

Choose a reason for hiding this comment

zier-one commented Aug 15, 2019

huaouo commented Aug 10, 2019 •

edited

Loading

CLAassistant commented Aug 10, 2019 •

edited

Loading

codecov bot commented Aug 10, 2019 •

edited

Loading