Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: support secondary_load and secondary_unload #496

Merged
merged 6 commits into from
Aug 20, 2019

Conversation

spongedu
Copy link
Contributor

@spongedu spongedu commented Aug 18, 2019

What problem does this PR solve?

Fix #444 , support SECONDARY_LOAD and SECONDARY_UNLOAD option in ALTER TABLE syntax

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

Related changes

N / A

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #496 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   71.48%   71.49%   +0.01%     
==========================================
  Files          32       32              
  Lines        7672     7676       +4     
==========================================
+ Hits         5484     5488       +4     
  Misses       1667     1667              
  Partials      521      521
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 79.96% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9e53e...59dc364. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #496 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   71.49%   71.49%   +<.01%     
==========================================
  Files          32       32              
  Lines        7675     7676       +1     
==========================================
+ Hits         5487     5488       +1     
  Misses       1667     1667              
  Partials      521      521
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 79.96% <100%> (+0.01%) ⬆️
ast/misc.go 74.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57ca26...1ccfe04. Read the comment docs.

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

ast/ddl.go Outdated Show resolved Hide resolved
@kennytm kennytm added the status/LGT1 LGT1 label Aug 18, 2019
zier-one
zier-one previously approved these changes Aug 19, 2019
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 19, 2019
@zier-one
Copy link
Contributor

@spongedu resolve conflicts please

@zier-one
Copy link
Contributor

@spongedu could you resolve conflicts after we merged #505

@zier-one zier-one merged commit 96e1f76 into pingcap:master Aug 20, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix SECONDARY_LOAD/SECONDARY_UNLOAD syntax
4 participants