parser: support ALTER TABLE ALTER CHECK, ALTER TABLE DROP CHECK syntax
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spongedu
changed the title
ALTER TABLE ALTER CHECK, ALTER TABLE DROP CHECK s…ALTER TABLE ALTER CHECK, ALTER TABLE DROP CHECK syntax
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=========================================
+ Coverage 71.56% 71.6% +0.03%
=========================================
Files 32 32
Lines 7703 7712 +9
=========================================
+ Hits 5513 5522 +9
Misses 1668 1668
Partials 522 522
Continue to review full report at Codecov.
|
|
LGTM |
|
@tangenta PTAL |
tangenta
reviewed
Aug 20, 2019
parser.y
Outdated
| @@ -1607,6 +1607,33 @@ AlterTableSpec: | |||
| yylex.AppendError(yylex.Errorf("The WITH/WITHOUT VALIDATION clause is parsed but ignored by all storage engines.")) | |||
| parser.lastErrorAsWarn() | |||
| } | |||
| | "ALTER" "CHECK" Identifier EnforcedOrNot | |||
There was a problem hiding this comment.
Suggested change
| | "ALTER" "CHECK" Identifier EnforcedOrNot | |
| | "ALTER" "CHECK" Identifier EnforcedOrNot |
Sorry for my unclear suggestion. I mean here should be a tab, as most of the other productions.
parser_test.go
Outdated
| @@ -2284,6 +2284,13 @@ func (s *testParserSuite) TestDDL(c *C) { | |||
| {"ALTER TABLE t RENAME KEY a TO b;", true, "ALTER TABLE `t` RENAME INDEX `a` TO `b`"}, | |||
| {"ALTER TABLE t RENAME INDEX a TO b;", true, "ALTER TABLE `t` RENAME INDEX `a` TO `b`"}, | |||
|
|
|||
| // For #497 | |||
|
|
|||
There was a problem hiding this comment.
Please remove this blank line.
There was a problem hiding this comment.
Please remove this blank line.
OK.
58 tasks
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
for #497 , suport
ALTER TABLE ALTER CHECK,ALTER TABLE DROP CHECKsyntax.Check List
Tests
Code changes
N / A
Side effects
N / A
Related changes
N / A