Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add support for SHUTDOWN syntax #580

Merged
merged 6 commits into from
Oct 21, 2019
Merged

parser: add support for SHUTDOWN syntax #580

merged 6 commits into from
Oct 21, 2019

Conversation

ekalinin
Copy link
Contributor

@ekalinin ekalinin commented Oct 16, 2019 •
edited
Loading

What problem does this PR solve?

What is changed and how it works?

add a new syntax for:

  • a SHUTDOWN command
  • a SHUTDOWN privilege

Check List

Tests

  • Unit test

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@ekalinin ekalinin requested a review from a team October 16, 2019 22:36
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ekalinin ekalinin mentioned this pull request Oct 17, 2019
Merged
@ekalinin ekalinin changed the title add support for SHUTDOWN syntax parser: add support for SHUTDOWN syntax Oct 17, 2019
kennytm
kennytm reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@488522f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #580   +/-   ##
=========================================
  Coverage          ?   71.86%           
=========================================
  Files             ?       32           
  Lines             ?     7843           
  Branches          ?        0           
=========================================
  Hits              ?     5636           
  Misses            ?     1676           
  Partials          ?      531
Impacted Files Coverage Δ
misc.go 96.49% <ø> (ø)
mysql/const.go 25.27% <ø> (ø)
parser.go 70.37% <ø> (ø)
ast/misc.go 74.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488522f...aefec12. Read the comment docs.

tangenta
tangenta previously approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 19, 2019
@kennytm kennytm merged commit 7c64f78 into pingcap:master Oct 21, 2019
@ekalinin ekalinin deleted the 136/add-shutdown-cmd branch October 21, 2019 08:39
@lysu lysu mentioned this pull request Dec 18, 2019
Merged
lysu added a commit that referenced this pull request Dec 18, 2019
@lysu
parser: add support for SHUTDOWN syntax (#580) (#688)
56b91da
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@ekalinin @kennytm
parser: add support for SHUTDOWN syntax (pingcap#580)
3029fca 
* add support for SHUTDOWN syntax

* add SHUTDOWN privilege syntax
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@ekalinin @kennytm
parser: add support for SHUTDOWN syntax (pingcap#580)
deedaeb 
* add support for SHUTDOWN syntax

* add SHUTDOWN privilege syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@tangenta tangenta tangenta left review comments

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekalinin @CLAassistant @kennytm @tangenta @you06