Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: add support for SHUTDOWN syntax (#580) #688

Merged
merged 1 commit into from
Dec 18, 2019
Merged

parser: add support for SHUTDOWN syntax (#580) #688

merged 1 commit into from
Dec 18, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Dec 18, 2019 •
edited
Loading

cherry-pick #580 to 3.0

just re-generate parser.go

This change is Reviewable

@ekalinin @lysu
parser: add support for SHUTDOWN syntax (#580)
b524fde 
* add support for SHUTDOWN syntax

* add SHUTDOWN privilege syntax
@lysu lysu requested review from imtbkcat and jackysp December 18, 2019 02:57
@lysu lysu mentioned this pull request Dec 18, 2019
Merged
@lysu
Copy link
Collaborator Author

lysu commented Dec 18, 2019 •
edited
Loading

test with pingcap/tidb#14104 and CI will fixed after TiDB PR be merged

jackysp
jackysp reviewed Dec 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imtbkcat
imtbkcat approved these changes Dec 18, 2019
View reviewed changes
Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu merged commit 56b91da into pingcap:release-3.0 Dec 18, 2019
@lysu lysu deleted the cp30-shutdown branch December 18, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@imtbkcat imtbkcat imtbkcat approved these changes

Assignees
No one assigned
Labels
status/LGT1 LGT1 type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lysu @jackysp @imtbkcat @ekalinin