Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support flashback truncate table. #611

Merged
merged 6 commits into from
Dec 3, 2019
Merged

*: support flashback truncate table. #611

merged 6 commits into from
Dec 3, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

This is for PR: pingcap/tidb#13109

Add syntax :

flashback table t until timestamp '2019-11-04 11:56:49.497 +0800 CST' to t1;

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Possible performance regression

Related changes

@crazycs520 crazycs520 requested a review from a team November 4, 2019 04:07
@ghost ghost requested review from tangenta and removed request for a team November 4, 2019 04:07
tiancaiamao
tiancaiamao reviewed Nov 6, 2019
View reviewed changes
parser.y Outdated Show resolved Hide resolved
@kennytm
Copy link
Contributor

kennytm commented Nov 6, 2019

Is the syntax finalized? Wanna note that Oracle's FLASHBACK syntax is slightly different.

FLASHBACK TABLE t TO TIMESTAMP '2019-10-31 23:59:58';
FLASHBACK TABLE t TO BEFORE DROP RENAME TO `t1`;
FLASHBACK DATABASE db TO TIMESTAMP '2019-10-31 23:59:58';
FLASHBACK DATABASE db TO BEFORE TIMESTAMP '2019-10-31 23:59:59';

@crazycs520 crazycs520 mentioned this pull request Nov 27, 2019
Merged
@crazycs520
Copy link
Contributor Author

@kennytm, The syntax is finalized, the difference with oracle is intentional

@tiancaiamao
Copy link
Collaborator

LGTM @kennytm

AilinKid
AilinKid reviewed Dec 3, 2019
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 3, 2019
@crazycs520 crazycs520 merged commit 55f02bc into pingcap:master Dec 3, 2019
@crazycs520 crazycs520 mentioned this pull request Feb 3, 2020
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@crazycs520
*: add flashback table syntax (pingcap#611)
e8c68f2
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@crazycs520
*: add flashback table syntax (pingcap#611)
884ad42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@AilinKid AilinKid AilinKid approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @kennytm @tiancaiamao @AilinKid