*: refine flashback syntax by remove until timestamp statement. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
AilinKid
reviewed
Feb 7, 2020
|
@AilinKid Since this PR doesn't compatible, so it can't pass the integration test, it need merge with TiDB PR at the same time. |
Oh, got |
AilinKid
approved these changes
Feb 7, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PR #611 add the
flashbacksyntax. But it was hard to use with theuntil timestampstatement.And currently, we can't support
flashbackto any timestamp, even in the GC safe time.After think over and talk with PM, we decided to remove the
until timestampstatement in theflashbacksyntax. Now theflashbacksyntax is like below:What is changed and how it works?
Check List
Tests