Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: implement Restore for IndexColName #91

Merged
merged 20 commits into from
Dec 24, 2018

Conversation

feloxx
Copy link
Contributor

@feloxx feloxx commented Dec 20, 2018

  1. implement Restore for IndexColName

Issue: pingcap/tidb#8532

ast/ddl.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and resolve conflicts please

@zier-one zier-one added the status/LGT1 LGT1 label Dec 21, 2018
@zier-one zier-one self-assigned this Dec 21, 2018
ast/ddl_test.go Outdated Show resolved Hide resolved
@kennytm kennytm added DNM and removed DNM labels Dec 21, 2018
@zier-one
Copy link
Contributor

@kennytm PTAL

kennytm
kennytm previously approved these changes Dec 24, 2018
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please fix CI, however.

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 24, 2018
@zier-one zier-one merged commit fe0bd4d into pingcap:master Dec 24, 2018
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants