Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for IndexColName #91

Merged
merged 20 commits into from
Dec 24, 2018
Merged

parser: implement Restore for IndexColName #91

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
bd78bdd
implement Restore for IndexColName
Dec 20, 2018
ef3c50d
Add test case
Dec 20, 2018
21582bf
Del other case
Dec 20, 2018
a97f5f0
Change test case
Dec 20, 2018
0745ddc
Merge branch 'master' into feature/Resotre_IndexColName
Dec 21, 2018
6249446
Merge branch 'master' into feature/Resotre_IndexColName
Dec 21, 2018
e7d17e9
Merge branch 'master' into feature/Resotre_IndexColName
Dec 21, 2018
7e486e0
Change test case
Dec 21, 2018
01456ec
Merge branch 'feature/Resotre_IndexColName' of github.com:feloxx/pars…
Dec 21, 2018
c6f11ab
Del
Dec 21, 2018
c1417b3
Merge branch 'master' into feature/Resotre_IndexColName
feloxx Dec 21, 2018
2efa45e
del
Dec 21, 2018
d75d733
del
Dec 21, 2018
e0923d0
Del
Dec 21, 2018
d941f23
format
Dec 21, 2018
60498b3
Merge branch 'master' into feature/Resotre_IndexColName
Dec 24, 2018
bb270e9
Merge branch 'master' into feature/Resotre_IndexColName
feloxx Dec 24, 2018
7c84898
fix
Dec 24, 2018
dabea55
fmt
Dec 24, 2018
1efad78
space
Dec 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ast/ddl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,13 @@ type IndexColName struct {

// Restore implements Node interface.
func (n *IndexColName) Restore(ctx *RestoreCtx) error {
return errors.New("Not implemented")
if err := n.Column.Restore(ctx); err != nil {
return errors.Annotate(err, "An error occurred while splicing IndexColName")
}
if n.Length > 0 {
ctx.WritePlainf("(%d)",n.Length)
}
return nil
}

// Accept implements Node Accept interface.
Expand Down
11 changes: 11 additions & 0 deletions ast/ddl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,17 @@ func (ts *testDDLSuite) TestDDLVisitorCover(c *C) {
}
}

func (ts *testDDLSuite) TestDDLIndexColNameRestore(c *C) {
testCases := []NodeRestoreTestCase{
{"world", "`world`"},
{"world(2)", "`world`(2)"},
}
extractNodeFunc := func(node Node) Node {
return node.(*CreateIndexStmt).IndexColNames[0]
}
RunNodeRestoreTest(c, testCases, "CREATE INDEX idx ON t (%s) USING HASH", extractNodeFunc)
}

func (ts *testDDLSuite) TestDDLIndexOption(c *C) {
testCases := []NodeRestoreTestCase{
{"key_block_size=16", "KEY_BLOCK_SIZE=16"},
Expand Down