fix potential panic when read last line #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <chen.two.cs@gmail.com>
breezewish
reviewed
Jul 30, 2021
| buf = buf[:stackSize] | ||
| err = fmt.Errorf(fmt.Sprintf("search log panic, %v, stack is %v", r, string(buf))) | ||
| log.Error(err.Error()) | ||
| } |
There was a problem hiding this comment.
Should we return err to the outside?
There was a problem hiding this comment.
The error already returns to the outside since line 47 assign value to err.
breezewish
reviewed
Jul 30, 2021
breezewish
approved these changes
Jul 30, 2021
This was referenced Jul 30, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs chen.two.cs@gmail.com
Close issue: #29
This PR does 2 things: