Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update sysutil in go.mod to fix panic when search log #3929

Merged
merged 2 commits into from
Aug 2, 2021

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs chen.two.cs@gmail.com

What problem does this PR solve?

Update sysutil in go.mod for pingcap/sysutil#31.

Check List

Tests

  • No code

Release note

None

Signed-off-by: crazycs <chen.two.cs@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 30, 2021
@ti-chi-bot ti-chi-bot requested review from nolouch and rleungx July 30, 2021 13:05
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #3929 (2b31ad0) into master (fb61469) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3929      +/-   ##
==========================================
- Coverage   74.65%   74.52%   -0.13%     
==========================================
  Files         246      246              
  Lines       25059    25059              
==========================================
- Hits        18708    18676      -32     
- Misses       4695     4716      +21     
- Partials     1656     1667      +11     
Flag Coverage Δ
unittests 74.52% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-8.52%) ⬇️
server/kv/etcd_kv.go 72.46% <0.00%> (-7.25%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 77.46% <0.00%> (-4.23%) ⬇️
server/election/leadership.go 83.90% <0.00%> (-3.45%) ⬇️
server/election/lease.go 94.91% <0.00%> (-1.70%) ⬇️
server/member/member.go 65.24% <0.00%> (-1.07%) ⬇️
server/schedule/operator_controller.go 84.75% <0.00%> (-0.80%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-0.67%) ⬇️
client/base_client.go 82.29% <0.00%> (-0.53%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb61469...2b31ad0. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2021
@nolouch
Copy link
Contributor

nolouch commented Aug 2, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b31ad0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2021
@ti-chi-bot ti-chi-bot merged commit a14275e into tikv:master Aug 2, 2021
nolouch added a commit to nolouch/pd that referenced this pull request Aug 2, 2021
Signed-off-by: crazycs <chen.two.cs@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants