*: make drainer translator's SQL_MODE configurable #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
kennytm
reviewed
Apr 1, 2019
|
/run-all-tests |
|
LGTM |
july2993
reviewed
Apr 1, 2019
There was a problem hiding this comment.
- when the downstream is mysql, we need to set sql_mode in
drainer/executor/mysql.gotoo, or will fail to execute at the downstream mysql or tidb? - this means later we must support set sql_mode for
reparotoo, but it's ok to just do the drainer part now at this pr.
july2993
reviewed
Apr 1, 2019
|
/run-all-tests |
kennytm
reviewed
Apr 1, 2019
pkg/sql/sql.go
Outdated
| dbDSN := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4,utf8&multiStatements=true", username, password, host, port) | ||
| if len(sqlMode) > 0 { |
There was a problem hiding this comment.
So it's not possible to set an empty SQL mode (which is different from the "default SQL mode" which includes STRICT_TRANS_TABLE and stuff)?
csuzhangxc
reviewed
Apr 1, 2019
|
except adding some new arguments into functions, LGTM. I think we can put sql mode into |
if downstream is MySQL, put it into DBConfig is fine, but if the downstream is pb, we still need another config item to hold it, right? |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
relate issue:https://internal.pingcap.net/jira/browse/TOOL-1039
Drainer translator should keep SQL_MODE compatible with upstream.
What is changed and how it works?
Add a config item
sql-modeto make SQL_MODE configurable.Check List
Tests
Code changes
Side effects
N/A
Related changes