Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add sql-mode config for drainer (#511) #513

Merged
merged 1 commit into from
Apr 1, 2019
Merged

*: Add sql-mode config for drainer (#511) #513

merged 1 commit into from
Apr 1, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Apr 1, 2019

What problem does this PR solve?

cherry-pick: #511

What is changed and how it works?

If this is setted , will use the same sql-mode to parse DDL statment, and set the same sql-mode at downstream when db-type is mysql.
If this is not setted, it will not set any sql-mode.

(cherry picked from commit 06e378f)

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

N/A

If this is setted , will use the same sql-mode to parse DDL statment, and set the same sql-mode at downstream when db-type is mysql.
If this is not setted, it will not set any sql-mode.

(cherry picked from commit 06e378f)
@lonng
Copy link
Contributor Author

lonng commented Apr 1, 2019

/run-all-tests

@july2993 july2993 merged commit 2db959a into pingcap:release-2.1 Apr 1, 2019
@july2993 july2993 deleted the sql-mode-cherry-pick branch April 1, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants