Return error when loading some undefined configs from local #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
commented
Jul 23, 2019
lichunzhu
changed the title
lichunzhu
changed the title
suzaku
reviewed
Jul 23, 2019
july2993
reviewed
Jul 24, 2019
suzaku
reviewed
Jul 24, 2019
… for unrecognized option, make the unrecognized option test more strict, change error handle way in /*/config.go
suzaku
reviewed
Jul 24, 2019
lichunzhu
force-pushed
the
czli/handleInvalidTomlOptions
branch
from
c2a0872
to
827732d
Compare
suzaku
reviewed
Jul 24, 2019
kennytm
approved these changes
Jul 24, 2019
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
TOOL-1403
Referral PR: TiDB#9855
What is changed and how it works?
Now func
configFromFileinconfig.goof drainer, pump, arbiter, reparo will make sure that there is no undecoded args inmetaData. This can help customers check their misspell in the config toml files. Relative tests have been added, too.Check List
Tests
Code changes
Side effects
Related changes