Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when loading some undefined configs from local #708

Merged

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

TOOL-1403
Referral PR: TiDB#9855

What is changed and how it works?

cherry-pick: #687
Now func configFromFile in config.go of drainer, pump, arbiter, reparo will make sure that there is no undecoded args in metaData. This can help customers check their misspell in the config toml files. Relative tests have been added, too.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@zyxbest
Copy link
Contributor

zyxbest commented Aug 12, 2019

/run-unit-test

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku suzaku merged commit 7123aba into pingcap:release-2.1 Aug 13, 2019
@lichunzhu lichunzhu deleted the czli/2.1/handleInvalidTomlOptions branch September 2, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants