Fix default tidb-drainer config #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner config format
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
1 similar comment
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
|
|
/ok-to-test |
|
/run-e2e-in-kind |
|
@WangXiangUSTC @july2993 Could you please take a look? |
weekface
previously approved these changes
Aug 21, 2019
|
start from 2.1.16, pump/drainer will return error when loading some undefined configs: pingcap/tidb-binlog#708
I will suggest compressor as "" default, rest LGTM |
|
@july2993 Addressed your review comment. To all reviewers: PTAL again. Thanks. |
weekface
approved these changes
Aug 21, 2019
|
/run-e2e-in-kind |
|
/run-e2e-test |
|
/run-e2e-test |
aylei
added a commit
that referenced
this pull request
Nov 18, 2019
…compatible with the (#1164) * Fix default tidb-drainer config to be compatible with the latest drainer config format * Disable payload compression by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#792
What is changed and how does it work?
Default tidb-drainer config is adjusted to be compatible with the latest drainer config format.
To be more specific:
detect-interval is moved out from [syncer]
db-type value is changed from pb to file
compression is moved out from [syncer] and renamed to compressor
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: