Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable allow_auto_random_explicit_insert if it's suppported #976

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Jun 1, 2020

What problem does this PR solve?

pick #975
After pingcap/tidb#17102 unable to replicate auto random table.

the pr add a session system var allow_auto_random_explicit_insert, default is false, must enable for insert value explicit, or can't
replicate. This is unfriendly for replication or restores tools.

the test is disabled in #971 temporarily.

What is changed and how it works?

Enable allow_auto_random_explicit_insert if ths sys var is supported.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    test with version support and not support this var.

Release note

  • Enable allow_auto_random_explicit_insert automatic.

)

* Enable allow_auto_random_explicit_insert if it's suppported

Added by pingcap/tidb#17102
default is false, must enable for insert value explicit, or can't
replicate.
@july2993
Copy link
Contributor Author

july2993 commented Jun 1, 2020

/run-all-tests

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one
Copy link
Contributor

zier-one commented Jun 1, 2020

LGTM

@july2993 july2993 merged commit cde1d7f into pingcap:release-3.1 Jun 1, 2020
@july2993 july2993 deleted the pick_auto branch June 1, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants