sessionctx, executor: add session var to control explicit insertion on auto_random column #17102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…random column is allowed
tangenta
added
sig/execution
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #17102 +/- ##
===========================================
Coverage 79.9121% 79.9121%
===========================================
Files 520 520
Lines 140269 140269
===========================================
Hits 112092 112092
Misses 19217 19217
Partials 8960 8960 |
djshow832
reviewed
May 12, 2020
tangenta
changed the title
djshow832
reviewed
May 12, 2020
@djshow832 Although I think the case is rare, imagine there are two sessions: Global variable cannot meet the demand. |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 27, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17436 |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
May 31, 2020
Added by pingcap/tidb#17102 default is false, must enable for insert value explicit, or can't replicate.
july2993
added a commit
to pingcap/tidb-binlog
that referenced
this pull request
Jun 1, 2020
* Enable allow_auto_random_explicit_insert if it's suppported Added by pingcap/tidb#17102 default is false, must enable for insert value explicit, or can't replicate.
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Jun 1, 2020
) * Enable allow_auto_random_explicit_insert if it's suppported Added by pingcap/tidb#17102 default is false, must enable for insert value explicit, or can't replicate.
july2993
added a commit
to pingcap/tidb-binlog
that referenced
this pull request
Jun 1, 2020
) * Enable allow_auto_random_explicit_insert if it's suppported Added by pingcap/tidb#17102 default is false, must enable for insert value explicit, or can't replicate.
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Jul 13, 2020
…n auto_random column (pingcap#17102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
As the documentation says,
This PR adds a session variable named
tidb_allow_auto_random_explicit_insert, which controls whether explicit insertion on auto_random column is allowed. By default, it isfalse.What is changed and how it works?
What's Changed:
tidb_allow_auto_random_explicit_insert.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note
tidb_allow_auto_random_explicit_insertis added, which controls whether explicit insertion on auto_random column is allowed.