Skip to content

Commit

Permalink
chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)
Browse files Browse the repository at this point in the history
  • Loading branch information
baurine authored Aug 22, 2023
1 parent ae6e959 commit 58349be
Show file tree
Hide file tree
Showing 7 changed files with 5,113 additions and 668 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ jobs:
uses: actions/checkout@v3
# https://pnpm.io/continuous-integration#github-actions
- name: Setup PNPM
uses: pnpm/action-setup@v2.2.2
uses: pnpm/action-setup@v2
with:
version: 7
version: 8
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: "16"
node-version: "18"
cache: "pnpm"
cache-dependency-path: "ui/pnpm-lock.yaml"
- uses: actions/setup-go@v3
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ jobs:
uses: actions/checkout@v3
# https://pnpm.io/continuous-integration#github-actions
- name: Setup PNPM
uses: pnpm/action-setup@v2.2.2
uses: pnpm/action-setup@v2
with:
version: 7
version: 8
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '16'
cache: 'pnpm'
cache-dependency-path: 'ui/pnpm-lock.yaml'
node-version: "18"
cache: "pnpm"
cache-dependency-path: "ui/pnpm-lock.yaml"
- uses: actions/setup-go@v3
with:
go-version: "1.18"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/upload-e2e-snapshots.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,13 @@ jobs:
ref: ${{ github.event.inputs.ref }}
# https://pnpm.io/continuous-integration#github-actions
- name: Setup PNPM
uses: pnpm/action-setup@v2.2.2
uses: pnpm/action-setup@v2
with:
version: 7
version: 8
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: "16"
node-version: "18"
cache: "pnpm"
cache-dependency-path: "ui/pnpm-lock.yaml"
- uses: actions/setup-go@v3
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ The followings are required for developing TiDB Dashboard:
- git - Version control
- make - Build tool (run common workflows)
- [Golang 1.19+](https://golang.org/) - To compile the server.
- [Node.js 16](https://nodejs.org/) - To compile the front-end.
- [PNPM 7](https://pnpm.io/) - To manage front-end dependencies.
- [Node.js 18](https://nodejs.org/) - To compile the front-end.
- [PNPM 8](https://pnpm.io/) - To manage front-end dependencies.
- [Java 8+](https://www.java.com/ES/download/) - To generate JavaScript API client by OpenAPI specification.

### Step 3. Build and Run TiDB Dashboard
Expand Down
5 changes: 5 additions & 0 deletions ui/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

![ui arch](./ui_arch.png)

## Requirements

- Node >= 18.16.0
- pnpm >= 8.6.12

## Run

### Dev
Expand Down
2 changes: 1 addition & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "1.0.0",
"license": "MIT",
"engines": {
"node": ">=16.16.0"
"node": ">=18.16.0"
},
"scripts": {
"fmt-check": "prettier --check .",
Expand Down
Loading

0 comments on commit 58349be

Please sign in to comment.