Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade node from 16 to 18, pnpm from 7 to 8 #1580

Merged
merged 1 commit into from
Aug 22, 2023
Merged

chore: upgrade node from 16 to 18, pnpm from 7 to 8 #1580

merged 1 commit into from
Aug 22, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Aug 22, 2023

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 22, 2023 06:00
@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 06b27f7
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64e457774bd43f0008ba8c6b
😎 Deploy Preview https://deploy-preview-1580--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for tidb-dashboard-for-dbaas ready!

Name Link
🔨 Latest commit 06b27f7
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard-for-dbaas/deploys/64e45776c49f2a000811da0f
😎 Deploy Preview https://deploy-preview-1580--tidb-dashboard-for-dbaas.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/XXL label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Merging #1580 (aff927b) into master (ae6e959) will not change coverage.
The diff coverage is n/a.

❗ Current head aff927b differs from pull request most recent head 06b27f7. Consider uploading reports for the commit 06b27f7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1580   +/-   ##
=======================================
  Coverage   24.68%   24.68%           
=======================================
  Files         168      168           
  Lines       15097    15097           
=======================================
  Hits         3726     3726           
  Misses      11097    11097           
  Partials      274      274
Flag Coverage Δ
backend_integration 9.10% <ø> (-0.04%) ⬇️
backend_ut 26.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6e959...06b27f7. Read the comment docs.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 06:48:29.622286723 +0000 UTC m=+1218474.171302712: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 22, 2023
@baurine baurine added this pull request to the merge queue Aug 22, 2023
@baurine baurine removed this pull request from the merge queue due to a manual request Aug 22, 2023
@baurine baurine merged commit 58349be into master Aug 22, 2023
26 checks passed
@baurine baurine deleted the chore/upgrade-node-pnpm branch August 22, 2023 06:55
baurine added a commit that referenced this pull request Sep 11, 2023
@baurine
chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)
c1805c3
baurine added a commit that referenced this pull request Sep 11, 2023
@baurine @shhdgit
@SabaPing @nolouch @mornyx
Release v2023.09.11.01 [skip pd_pr] (#1588)
22add1e 
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shhdgit shhdgit shhdgit approved these changes

@Renkai Renkai Awaiting requested review from Renkai

Assignees
No one assigned
Labels
approved area/frontend lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baurine @shhdgit