Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(binary-plan): show eye icon to hide column when hover #1574

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Aug 16, 2023

Preview

Kapture.2023-08-16.at.11.38.20.mp4

@ti-chi-bot ti-chi-bot bot requested a review from Renkai August 16, 2023 03:13
@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for tidb-dashboard-for-dbaas failed.

Name Link
🔨 Latest commit 9ba6424
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard-for-dbaas/deploys/64dc3edc30baa4000805c4be

@netlify
Copy link

netlify bot commented Aug 16, 2023

Deploy Preview for tidb-dashboard failed.

Name Link
🔨 Latest commit 9ba6424
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64dc3edc6f57230008181781

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1574 (9ba6424) into master (9752633) will increase coverage by 15.57%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1574       +/-   ##
===========================================
+ Coverage    9.10%   24.68%   +15.57%     
===========================================
  Files         122      168       +46     
  Lines       12807    15097     +2290     
===========================================
+ Hits         1166     3726     +2560     
+ Misses      11519    11097      -422     
- Partials      122      274      +152     
Flag Coverage Δ
backend_integration 9.14% <ø> (+0.03%) ⬆️
backend_ut 26.55% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9752633...9ba6424. Read the comment docs.

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 05:46:21.364890983 +0000 UTC m=+696345.913906968: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 7afbad0 into master Aug 16, 2023
10 of 18 checks passed
@ti-chi-bot ti-chi-bot bot deleted the chore/refine-execution-plan branch August 16, 2023 05:47
baurine added a commit that referenced this pull request Sep 11, 2023
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants