Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(login): fix login integration test #1587

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Sep 8, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit 2026452
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/64fe80dec5082e0008134426

@ti-chi-bot ti-chi-bot bot requested a review from Renkai September 8, 2023 09:20
@ti-chi-bot ti-chi-bot bot added the size/S label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1587 (2026452) into master (ded9a32) will decrease coverage by 1.73%.
The diff coverage is 72.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1587      +/-   ##
==========================================
- Coverage   26.42%   24.70%   -1.73%     
==========================================
  Files          97      169      +72     
  Lines       10443    15211    +4768     
==========================================
+ Hits         2760     3758     +998     
- Misses       7498    11171    +3673     
- Partials      185      282      +97     
Flag Coverage Δ
backend_integration 9.31% <72.72%> (?)
backend_ut 26.40% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded9a32...2026452. Read the comment docs.

@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Sep 8, 2023
@baurine baurine linked an issue Sep 8, 2023 that may be closed by this pull request
pkg/apiserver/user/auth.go Outdated Show resolved Hide resolved
@baurine baurine changed the title chore(security): make rsa key pair only use once for sql login test(login): fix login integration test Sep 11, 2023
@baurine baurine marked this pull request as ready for review September 11, 2023 03:07
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 11, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 03:09:17.009849088 +0000 UTC m=+238738.934405484: ☑️ agreed by shhdgit.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit f1e012a into master Sep 11, 2023
13 of 14 checks passed
@ti-chi-bot ti-chi-bot bot deleted the chore/update-login-security branch September 11, 2023 03:10
baurine added a commit that referenced this pull request Sep 11, 2023
baurine added a commit that referenced this pull request Sep 11, 2023
* feat(execution-plan): refine execution plan (#1561)

* chore(binary-plan): truncate long operator info for execution plan (#1565)

* feat: fix and refine execution plan (#1568)

* chore(binary-plan): show eye icon to hide column when hover (#1574)

* bump: i18next (#1575)

* Remove PNPM_INSTALL_TAGS=--offline (#1578)

* chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580)

* feat(conprof): show conprof download link for TiCDC (#1581)

* keyvisual: use scanRegions instead of fetch all regions (#1579)

* feat(resource-control): show resource control entry for clinic (#1582)

* feat(debug-api): support pagination for ddl history (#1584)

* feat(security): encrypt login password (#1583)

* chore: update swaggo (#1585)

* test(login): fix login integration test (#1587)

* update release version to 2023.09.11.1

---------

Co-authored-by: Suhaha <jklopsdfw@gmail.com>
Co-authored-by: Yifan Xu <xuyifan02@pingcap.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
baurine added a commit that referenced this pull request Nov 2, 2023
baurine added a commit that referenced this pull request Nov 2, 2023
* Revert "test(login): fix login integration test (#1587)"

This reverts commit f1e012a.

* Revert "feat(security): encrypt login password (#1583)"

This reverts commit d010da5.

* update release version to 2023.11.02.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix failed login integration test
2 participants