-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conprof): show conprof download link for TiCDC #1581
Conversation
✅ Deploy Preview for tidb-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4ae5b2e
to
f0a6a9d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1581 +/- ##
=======================================
Coverage 24.68% 24.68%
=======================================
Files 168 168
Lines 15097 15097
=======================================
Hits 3726 3726
Misses 11097 11097
Partials 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
LGTM, but why the second pic shows the connection refused? What does that mean? |
It's the ngm service error, I don't know why it doesn't work normally, need @mornyx 's help. But for frontend, it shows the correct content from the API. |
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mornyx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* feat(execution-plan): refine execution plan (#1561) * chore(binary-plan): truncate long operator info for execution plan (#1565) * feat: fix and refine execution plan (#1568) * chore(binary-plan): show eye icon to hide column when hover (#1574) * bump: i18next (#1575) * Remove PNPM_INSTALL_TAGS=--offline (#1578) * chore: upgrade node from 16 to 18, pnpm from 7 to 8 (#1580) * feat(conprof): show conprof download link for TiCDC (#1581) * keyvisual: use scanRegions instead of fetch all regions (#1579) * feat(resource-control): show resource control entry for clinic (#1582) * feat(debug-api): support pagination for ddl history (#1584) * feat(security): encrypt login password (#1583) * chore: update swaggo (#1585) * test(login): fix login integration test (#1587) * update release version to 2023.09.11.1 --------- Co-authored-by: Suhaha <jklopsdfw@gmail.com> Co-authored-by: Yifan Xu <xuyifan02@pingcap.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Yexiang Zhang <mornyx.z@gmail.com>
What Did
This PR supports to view TiCDC conprof status.
TODO: test compatibility with old versions (7.1, 6.5. 6.1)Test
Test in 7.3.0, 7.1.0, 6.5.3, 6.1.0.
6.1.0 doesn't show TiCDC component in conprof, because the ngm of this version doesn't support TiCDC.
others all show TiCDC component in conprof.
Preview
Run dev env:
The cluster and cdc are both 7.3.0 version.
Note: in my test environment, the ngm can't get the TiCDC profiles successfully, don't know why, so in the above screenshot, the status is
Partial Finished
, and in the detail page, the status forTiCDC
isError
, clicking theError Information
, it will show the error reason in the modal.